Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRELEASE-1091] Use non-interactive mode for forked Maven process #125

Merged
merged 1 commit into from
May 10, 2022
Merged

[MRELEASE-1091] Use non-interactive mode for forked Maven process #125

merged 1 commit into from
May 10, 2022

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

michael-o
michael-o approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally

@slawekjaranowski slawekjaranowski merged commit 4306a53 into master May 10, 2022
@slawekjaranowski slawekjaranowski deleted the MRELEASE-1091 branch May 10, 2022 07:41
@famod
Copy link

famod commented Jun 20, 2022 •
edited
Loading

This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra.
Before this change, when gpg-plugin runs, it triggered the cert password prompt window of Kleopatra but now it fails right away with no pinentry.

I don't think this effect is by design?

famod added a commit to famod/gitflow-incremental-builder that referenced this pull request Jun 20, 2022
@famod
Revert "Bump maven-release-plugin from 3.0.0-M5 to 3.0.0-M6"
7338672 
This reverts commit 71fa410.

Reason: apache/maven-release#125 (comment)
@michael-o
Copy link
Member

michael-o commented Jun 20, 2022 •
edited
Loading

This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra. Before this change, when gpg-plugin runs, it triggered the cert password prompt windows of Kleopatra but now it fails right away with no pinentry.

I don't think this effect is by design?

Very good catch. I use Gpg4win Kleopatra as well, but did not move to the new plugin version yet. This is likely the issue:

https://github.com/apache/maven-gpg-plugin/blob/525508093293cd1bb78d439cb28f2c48d7d79d9b/src/main/java/org/apache/maven/plugins/gpg/GpgSigner.java#L143-L154

@famod
Copy link

famod commented Jun 20, 2022

Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?

@michael-o
Copy link
Member

Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?

Well, to make it properly work from the beginning you need to use ProcessBuilder and inherit stdin for the forked process in interfactive mode. I consider the Command Executor we have as fucked up since it does not use it and wraps everything in a shell for some pointless reason. I think until this is done cleanly, your usecase must work, if no switch can be toggled for that, we need to revert.

@slawekjaranowski
Copy link
Member Author

ok, MSHARED-1072 to fix - I will take care about it

@famod
Copy link

famod commented Nov 3, 2022

@michael-o @slawekjaranowski 3.0.0-M7 still runs into this issue.

famod added a commit to famod/gitflow-incremental-builder that referenced this pull request Nov 3, 2022
@famod
Revert "Bump maven-release-plugin from 3.0.0-M5 to 3.0.0-M7"
48d7259 
This reverts commit 3804c82.

Reason: apache/maven-release#125 (comment)
@famod famod mentioned this pull request Nov 3, 2022
Closed
This was referenced Jan 23, 2023
Closed
Merged
@hboutemy
Copy link
Member

hboutemy commented Jan 24, 2023 •
edited
Loading

was a MRELEASE Jira issue https://issues.apache.org/jira/projects/MRELEASE created to track the "breaks interaction of maven-gpg-plugin" issue?

@famod
Copy link

famod commented Feb 7, 2023

@hboutemy

was a MRELEASE Jira issue https://issues.apache.org/jira/projects/MRELEASE created to track the "breaks interaction of maven-gpg-plugin" issue?

I have just created https://issues.apache.org/jira/browse/MRELEASE-1114

@hboutemy hboutemy mentioned this pull request May 19, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slawekjaranowski @famod @michael-o @hboutemy @olamy